-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SpotBugs] Remove unread protected field in Checker #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuston
reviewed
Jan 30, 2023
kaijchen
changed the title
[Refactor] Change abstract class Checker to interface
[SpotBugs] Ignore URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD in Checker
Jan 30, 2023
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
============================================
- Coverage 59.76% 59.76% -0.01%
Complexity 1768 1768
============================================
Files 205 205
Lines 11531 11530 -1
Branches 1033 1033
============================================
- Hits 6892 6891 -1
Misses 4233 4233
Partials 406 406
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
reviewed
Jan 30, 2023
kaijchen
changed the title
[SpotBugs] Ignore URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD in Checker
[SpotBugs] Remove unread protected field in Checker
Jan 30, 2023
advancedxy
approved these changes
Jan 31, 2023
Thanks @kaijchen |
Ref #532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Reduce SpotBugs exceptions.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.